- From: Mike West <notifications@github.com>
- Date: Mon, 07 Oct 2019 01:39:47 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/948/review/297974938@github.com>
mikewest commented on this pull request. > @@ -1567,13 +1573,13 @@ whose <a for=request>destination</a> is "<code>audio</code>", "<code>audioworkle "<code>object</code>" or "<code>embed</code>". <p>A <dfn export>non-subresource request</dfn> is a <a for=/>request</a> -whose <a for=request>destination</a> is "<code>document</code>", -"<code>report</code>", "<code>serviceworker</code>", "<code>sharedworker</code>", -or "<code>worker</code>". +whose <a for=request>destination</a> is "<code>document</code>", "<code>frame</code>", +"<code>iframe</code>", "<code>report</code>", "<code>serviceworker</code>", +"<code>sharedworker</code>", or "<code>worker</code>". Currently, `embed` and `object` are "potential-navigation-or-subresource" requests, and don't get categorized into either "subresource" or "non-subresource". I don't think this patch changes that. Looking at "display a plugin", it looks like `<embed>` and `<object>` will always create a nested browsing context. Is that how we're categorizing "subresource" vs "non-subresource"? If so, then I agree that it seems like we should lump them into the "non-subresource" bucket. It's not clear to me what the impact is there, though. Where is "non-subresource request" used? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/948#discussion_r331901031
Received on Monday, 7 October 2019 08:40:10 UTC