- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 02 Oct 2019 03:22:55 -0700
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 2 October 2019 10:23:17 UTC
marcoscaceres commented on this pull request. Couple of little nits @sonakshisaxena1. But looks good 👍 > @@ -1132,7 +1132,7 @@ <h2> </li> <li> <p> - <a>Handle functional event</a> "`push`" using <a>PushEvent</a> on + <a>Fire Functional Event</a> "`push`" using <a>PushEvent</a> on ```suggestion <a>Fire a functional event</a> named "`push`" using <a>PushEvent</a> on ``` > @@ -1188,7 +1188,7 @@ <h2> <p> To <dfn>fire the "`pushsubscriptionchange`" event</dfn> given a <a>service worker registration</a> of <var>registration</var>, <var>newSubscription</var> and - <var>oldSubscription</var>, the <a>user agent</a> must <a>handle functional event</a> + <var>oldSubscription</var>, the <a>user agent</a> must <a>Fire Functional Event</a> ```suggestion <var>oldSubscription</var>, the <a>user agent</a> must <a>fire a functional event</a> named ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/321#pullrequestreview-296143189
Received on Wednesday, 2 October 2019 10:23:17 UTC