Re: [w3ctag/design-reviews] [Payments] shipping and contact info delegation (#425)

A few other notes/questions (though I'm more concerned about my previous comment than this one):

-----

I'm a little curious about how the [proposed `PaymentDelegation` enum](https://github.com/sahel-sh/shipping-contact-delegation/blob/master/Explainer.md#enable-delegations) differs from the [`PaymentOptions` dictionary](https://w3c.github.io/payment-request/#dom-paymentoptions); the former has `shippingAddress` whereas the latter has `billingAddress` and `shipping` (with `request` at the front).  How do these correspond?  (And [`PaymentHandlerResponse`](https://w3c.github.io/payment-handler/#paymenthandlerresponse-dictionary) is in turn slightly different, with the added `shippingOption`.)

-----

This bit of the explainer:

> Payment handlers which support shipping delegation should be able to fire shipping[address|option]change events to let the merchant know that the user has selected a different shipping address/option. The browser will then get the updated request details from merchant and forward it to the payment handler after redacting displayItems.

seems a little confusing to me.  I would have expected the second sentence to describe how the browser moves the information from the payment handler to the merchant, not from the merchant to the payment handler.  If this is the correct direction, it might help to clarify exactly what's going on here.

-----

The [proposed `supported_delegations` member](https://github.com/sahel-sh/shipping-contact-delegation/blob/master/Explainer.md#edit-just-in-time-jit-installation) in Web App Manifest seems like it should probably have a name that makes it clear it's related to payments, since manifests are more general than just payments.  (Also, I think `PayerName` there should probably be lowercased as `payerName` to match the `enum PaymentDelegation` above.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/425#issuecomment-559291892