- From: Mattias Buelens <notifications@github.com>
- Date: Sat, 02 Nov 2019 04:28:20 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1021@github.com>
The spec text has broken links to the old [promises guide](https://www.w3.org/2001/tag/doc/promises-guide/). This is inconvenient for readers, but it also causes builds for spec PRs to fail (see [my comment on #1011](https://github.com/whatwg/streams/pull/1011#issuecomment-549029385)). This PR fixes the links by pointing to their new Web IDL counterparts. Todo list (non-exhaustive, feel free to suggest other changes): * [ ] Get spec to build again. * [ ] Figure out what to do with "promise-calling". * [ ] Change usages of "react to promise" to explicitly pass one or two sets of steps (as in [this example](https://heycam.github.io/webidl/#promise-example-addDelay)), instead of passing a "fulfillment handler" and a "rejection handler". * [ ] Change pairs of "upon fulfillment / upon rejection" to a single "react to promise". Fixes #1020 You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1021 -- Commit Summary -- * Change promises-guide references to webidl * Use "getting a promise to wait for all" -- File Changes -- M index.bs (24) -- Patch Links -- https://github.com/whatwg/streams/pull/1021.patch https://github.com/whatwg/streams/pull/1021.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1021
Received on Saturday, 2 November 2019 11:28:22 UTC