- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 24 May 2019 08:03:07 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 24 May 2019 15:03:29 UTC
domenic commented on this pull request. > @@ -1331,7 +1324,7 @@ requires buffering of scalar values. </dl> <p>The <dfn constructor for=TextEncoder id=dom-textencoder><code>TextEncoder()</code></dfn> -constructor, when invoked, must return a new {{TextEncoder}} object. +constructor, when invoked, must do nothing. I think I mainly thought "on getting, when invoked" was weird. Otherwise I was probably just going for local consistency. If we wanted a global pattern we should maybe discuss. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/175#discussion_r287399995
Received on Friday, 24 May 2019 15:03:29 UTC