Re: [w3c/selection-api] Several syntax amendments and tiny improvements (#106)

marcoscaceres requested changes on this pull request.

Some suggestions to quickly apply

> @@ -422,10 +423,10 @@ <h2>Selection interface</h2>
 
         <dt><dfn>deleteFromDocument</dfn></dt>
         <dd>
-          <p>The method must invoke <dfn><a href="https://dom.spec.whatwg.org/#dom-range-deletecontents"><code>deleteContents()</code></a></dfn> ([[!DOM]])
+          <p>The method must invoke <dfn><a href="!DOM#dom-range-deletecontents"><code>deleteContents()</code></a></dfn> ([[!DOM]])

Should be data-cite :) ... don't need ! anymore... will update those in a different PR. 
```suggestion
          <p>The method must invoke <dfn><a data-cite="DOM#dom-range-deletecontents"><code>deleteContents()</code></a></dfn> ([[DOM]])
```

> @@ -591,9 +593,9 @@ <h3><code><dfn>selectstart</dfn></code> event</h3>
 
         <p>When the user agent is about to associate a new range <var>newRange</var> to the <a>selection</a> in response to a user initiated action,
           the user agent must <dfn><a href="https://www.w3.org/TR/dom/#concept-event-fire">fire</a></dfn> ([[!DOM]])
-          an event with the name <code>selectstart</code>, which bubbles and is cancelable</a>,
-          at the <a>node</a> associated with the <a>boundary point</a> of <var>newRange</var>'s <a>start</a>
-          prior to changing the selection if the <a>selection</a> was previously <a>empty</a>
+          an event with the name <code>selectstart</code>, which <a href="!DOM#dom-event-bubbles">bubbles</a> and is
+          <a href="!DOM#dom-event-cancelable">cancelable</a>, at the <a>node</a> associated with the <a>boundary point</a> of <var>newRange</var>'s

```suggestion
          <a data-cite="DOM#dom-event-cancelable">cancelable</a>, at the <a>node</a> associated with the <a>boundary point</a> of <var>newRange</var>'s
```

> @@ -607,8 +609,8 @@ <h3><code><dfn>selectionchange</dfn></code> event</h3>
         <p>When the <a>selection</a> is dissociated with its <a>range</a>, associated with a new <a>range</a>
           or the associated <a>range</a>'s <a>boundary point</a> is mutated either by the user or the content script,
           the user agent must <dfn><a href="https://www.w3.org/html/wg/drafts/html/master/webappapis.html#queue-a-task">queue a task</a></dfn>
-          to <a>fire</a> an event with the name <code>selectionchange</code>, which does not bubble and is not cancelable</a>,
-          at the <a>document</a> associated with the <a>selection</a>.</p>
+          to <a>fire</a> an event with the name <code>selectionchange</code>, which does not <a href="!DOM#dom-event-bubbles">bubble</a> and is not
+          <a href="!DOM#dom-event-cancelable">cancelable</a>, at the <a>document</a> associated with the <a>selection</a>.</p>

```suggestion
          <a data-cite="DOM#dom-event-cancelable">cancelable</a>, at the <a>document</a> associated with the <a>selection</a>.</p>
```

> @@ -618,13 +620,14 @@ <h2>Acknowledgements</h2>
       <p>Many thanks to</p>
       <ul>
         <li><p>Aryeh Gregor, who is the original author of this specification as well as <a href="https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html">HTML Editing API specification</a>.</p></li>
-        <li><p>Contributors to the <a href="https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html">HTML Editing API specification</a> - 
+        <li><p>Contributors to the <a href="https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html">HTML Editing API specification</a> -

```suggestion
        <li>Contributors to the <a href="https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html">HTML Editing API specification</a> -
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/selection-api/pull/106#pullrequestreview-241008747