- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 17 May 2019 09:37:34 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 17 May 2019 16:37:56 UTC
domenic approved this pull request. LGTM with nit; nice simplification. > @@ -4767,13 +4766,11 @@ listed in the [=error names table=] below. The table also indicates the {{DOMException}}'s integer code for that error name, if it has one. -There are two types that can be used to refer to exception objects: -{{DOMException}} and {{Error!!interface}}, -where the latter encompasses [=simple exceptions=] and {{DOMException}}. +There is one type that can be used to refer to exception objects: +{{DOMException}}. I don't think this is a type any more? Or maybe it's just an interface type. In which case I think this paragraph is confusing; everything defined as an interface is an interface type. A paragraph like this makes me think I should find special conversion rules for the type. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/728#pullrequestreview-239020700
Received on Friday, 17 May 2019 16:37:56 UTC