Re: [heycam/webidl] Define Synthetic Module Records (#722)

littledan approved this pull request.

LGTM with stylistic suggestion that we could get back to later.

> +    <td>List of String
+    <td>A List of all names that are exported.
+  <tr>
+    <td>\[[EvaluationSteps]]
+    <td>An abstract operation
+    <td>An abstract operation that will be performed upon evaluation of the module, taking the
+        [=Synthetic Module Record=] as its sole argument.
+        These will usually set up the exported values, by using [$SetSyntheticModuleExport$].
+        They must not modify \[[ExportNames]].
+        They may return an abrupt completion.
+</table>
+
+<h4 id="createsyntheticmodule">CreateSyntheticModule</h4>
+
+<div algorithm>
+The abstract operation <dfn abstract-op>CreateSyntheticModule</dfn>(|exportNames|, |evaluationSteps|, |realm|, |hostDefined|) creates a [=Synthetic Module Record=] based upon

Since we are in WebIDL, I wonder if Create SyntheticModule and SetSyntheticModuleExport would be more clean if phrased as worded algorithms, e.g., "To <dfn>create a synthetic module record</dfn>...". HostDefined also seems redundant here when the steps can close over outer variables (as they can in web specs, but not JS).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/722#pullrequestreview-238098513