Re: [whatwg/dom] Add "disable shadow" flag check to Element.attachShadow() (#760)

Doesn't this fail to respect the disable-shadow flag for customized built-in elements on the safelist? E.g. `<h4 is="special-h4">` with

```js
customElements.define("special-h4", class extends HTMLHeadingElement {
  disabledFeatures = ['shadow'];
}, { extends: 'h4' });
```

I think we need to pass the node's `is value`. I will add a commit to do that, but we should also update the tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/760#issuecomment-492779049

Received on Wednesday, 15 May 2019 18:52:26 UTC