Re: [whatwg/dom] Add "disable shadow" flag check to Element.attachShadow() (#760)

tkent-google commented on this pull request.



> @@ -6770,6 +6770,22 @@ invoked, must run these steps:
  <li><p>If <a>context object</a> is a <a for=Element>shadow host</a>, then <a>throw</a> an
  "{{InvalidStateError!!exception}}" {{DOMException}}.
 
+ <li>
+  <p>If <a>context object</a>'s <a for=Element>local name</a> is a
+  <a>valid custom element name</a>, then:</p>
+
+  <ol>
+   <li><p>Let <var>definition</var> be the result of
+   <a lt="look up a custom element definition">looking up a custom element definition</a> given
+   <a>context object</a>'s <a for=Node>node document</a>, its <a for=Element>namespace</a>, its
+   <a for=Element>local name</a>, and null as <a><code>is</code> value</a>.</p></li>
+
+   <li><p>If <var>definition</var> is not null and <var>definition</var>'s
+   <a lt="concept-custom-element-definition-disable-shadow">disable shadow</a> is true,

ok, I understand your intention.
Then I think NotSupportedError is ok for all of four DOMExceptions thrown by attachShadow(). IMO InvalidStateError is a specific subset of NotSupportedError.

Anyway, this PR doesn't change the DOMException type of the already-attached case.  It's not in the scope of this PR.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/760#discussion_r284133855