- From: TAMURA, Kent <notifications@github.com>
- Date: Mon, 13 May 2019 01:35:24 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/760/review/236539923@github.com>
tkent-google commented on this pull request. > @@ -6770,6 +6770,22 @@ invoked, must run these steps: <li><p>If <a>context object</a> is a <a for=Element>shadow host</a>, then <a>throw</a> an "{{InvalidStateError!!exception}}" {{DOMException}}. + <li> + <p>If <a>context object</a>'s <a for=Element>local name</a> is a + <a>valid custom element name</a>, then:</p> + + <ol> + <li><p>Let <var>definition</var> be the result of + <a lt="look up a custom element definition">looking up a custom element definition</a> given + <a>context object</a>'s <a for=Node>node document</a>, its <a for=Element>namespace</a>, its + <a for=Element>local name</a>, and null as <a><code>is</code> value</a>.</p></li> + + <li><p>If <var>definition</var> is not null and <var>definition</var>'s + <a lt="concept-custom-element-definition-disable-shadow">disable shadow</a> is true, I thought that ```InvalidStateError``` was not suitable because the context object can't be 'valid' state again. But I found the context object was valid before calling custom element constructor. So ```InvalidStateError``` seems to make sense. ```attachInternals()``` has the same issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/760#discussion_r283238185
Received on Monday, 13 May 2019 08:35:46 UTC