Re: [w3c/IndexedDB] Add cursor.request (#257)

inexorabletash requested changes on this pull request.

Thanks for taking this on!

> @@ -4690,6 +4691,9 @@ object is modified, those modifications will be seen by anyone
 inspecting the value of the cursor. However modifying such an object
 does not modify the contents of the database.
 
+The <dfn attribute for=IDBCursor>request</dfn> attribute's getter must
+return the [=cursor/request=] of this [=cursor=].

FWIW, it looks like the spec uses "the cursor" more frequently than "this cursor". (Ideally the spec would be self-consistent already)

> @@ -4617,6 +4617,7 @@ interface IDBCursor {
   readonly attribute IDBCursorDirection direction;
   readonly attribute any key;
   readonly attribute any primaryKey;
+  readonly attribute IDBRequest request;

In addition to this IDL addition, please add a non-normative description to the  `domintro` block just below it (i.e. a new `dt`/`dd` pair), aimed at web developers and describing usage with need-to-know information.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/257#pullrequestreview-214098486

Received on Wednesday, 13 March 2019 17:22:18 UTC