- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 11 Mar 2019 21:33:02 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/171/review/213191754@github.com>
marcoscaceres commented on this pull request. > @@ -722,8 +722,12 @@ <h2> From the perspective of a <a>document</a>, locking to the <a>default orientation</a> is equivalent to unlocking because it means that it no longer has a lock applied. However, this does not - mean that the <a>[[\defaultOrientation]]</a> only contains the item - <a>any</a>. + mean that the <a>[[\defaultOrientation]]</a> should only contain + the item <a>any</a>. The <a>default orientation</a> is Can I suggest we change this section to: ``` <p> From the perspective of a <a>document</a>, locking to the <a>default orientation</a> is equivalent to unlocking because it means that it no longer has a lock applied. </p> <p class="note" title="Who controls the default orientation?"> This does not mean that the <a>[[\defaultOrientation]]</a> will only contain the item <a>any</a>. The <a>default orientation</a> is likely device-specific and <a>[[\defaultOrientation]]</a> could, for example, contain <a>portrait-primary</a> and/or <a>landscape-primary</a>. Alternatively, the user could restrict the default orientaiton to a specific orientation via some OS or browser level preference for accessiblity reasons. </p> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/171#pullrequestreview-213191754
Received on Tuesday, 12 March 2019 04:33:25 UTC