Re: [w3c/screen-orientation] BREAKING CHANGE: unlock() returns a pormise (#183)

I would be okay to have `unlock()` return a promise but I think we should have the spec be clearer about the situation. The change as it is assumes that you can `apply an orientation lock` to the `default orientotion` which isn't possible actually. #150 kind of touch this issue. Unless we want to solve it first (maybe we do?), one way to resolve this is to simply make the `unlock()` steps async and have it return a promise when it's done so it would be clear that we are not attempting to notify that the unlock orientation change happened but that the call was registered by the system. A note in the spec making this clear would be good too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/183#issuecomment-516212911

Received on Tuesday, 30 July 2019 00:35:49 UTC