- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 22 Jul 2019 23:21:03 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 23 July 2019 06:21:25 UTC
@mounirlamouri, could you check in Blink what you actually use for `defaultOrientation` when unlocking? From a quick search in the Blink code, it seems you also use a single value - but I wasn't able to find where it is defined (does Google have something like searchfox?). In Gecko, we use pass `eScreenOrientation_None` to the HAL. We could basically do the same thing in the spec by adding "default" or "none" to the `OrientationType` enum. The API itself would never return the value, but then we could pass it internally to `unlock()` to represent the "default orientations". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/183#issuecomment-514070559
Received on Tuesday, 23 July 2019 06:21:25 UTC