- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 31 Jan 2019 02:31:48 -0800
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/144/review/197370635@github.com>
marcoscaceres requested changes on this pull request.
Just minor thing, but want to check it once changes are done.
> + <th>
+ Internal Slot
+ </th>
+ <th>
+ Description (non-normative)
+ </th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td>
+ <dfn data-lt="orientation lock">[[\orientationLock]]</dfn>
+ </td>
+ <td>
+ A <a>document</a>'s orientation lock represented by an unordered
+ set of <a>orientationType</a>
```suggestion
set of <a>orientationType</a>.
```
> + </tr>
+ <tr>
+ <td>
+ <dfn data-lt=
+ "default orientation">[[\defaultOrientation]]</dfn>
+ </td>
+ <td>
+ The set of orientations to which the screen orientation is
+ locked when not explicitly locked by this API or any other
+ means.
+ </td>
+ </tr>
+ <tr>
+ <td>
+ <dfn data-lt=
+ "promiseToLockScreen">[[\promiseToLockScreen]]</dfn>
Remove the `data-lt` here. And always reference the internal slot like this:
```HTML
<a>[[\promiseToLockScreen]]</a>
```
Same with <a>defaultOrientation</a>
Remember, you can define the **concept** of "default orientation", which is represented by [[\defaultOrientation]].
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/144#pullrequestreview-197370635
Received on Thursday, 31 January 2019 10:32:12 UTC