- From: Mattias Buelens <notifications@github.com>
- Date: Wed, 30 Jan 2019 14:34:43 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 30 January 2019 22:35:04 UTC
MattiasBuelens commented on this pull request.
> @@ -399,11 +401,14 @@ like
get <a href="#rs-locked">locked</a>()
<a href="#rs-cancel">cancel</a>(reason)
- <a href="#rs-get-reader">getReader</a>()
+ <a href="#rs-get-iterator">getIterator</a>({ preventCancel } = {})
+ <a href="#rs-get-reader">getReader</a>({ mode } = {})
Drive-by fix: `getReader()` was missing its `{ mode }` argument in the class definition.
If you prefer I put this in a separate PR, let me know.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/980#pullrequestreview-198342536
Received on Wednesday, 30 January 2019 22:35:04 UTC