Re: [whatwg/streams] Add @@asyncIterator to ReadableStream (#980)

MattiasBuelens commented on this pull request.



>  }
 
+const AsyncIteratorPrototype = Object.getPrototypeOf(Object.getPrototypeOf(async function* () {}).prototype);
+const ReadableStreamAsyncIteratorPrototype = Object.setPrototypeOf({

New tests, new bugs. This way of setting up the prototype chain causes `next()` and `return()` to become enumerable properties... 🙄 

I guess I'll just resort to `Object.defineProperty` again? Or perhaps `Object.create` with a property descriptor map.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/980#pullrequestreview-198320546

Received on Wednesday, 30 January 2019 21:40:34 UTC