Re: [w3c/screen-orientation] Editorial: 2.1 Orientation attribute, 3. Screen Orientation and enums (#139)

marcoscaceres commented on this pull request.



> @@ -158,7 +162,39 @@ <h2>
             readonly attribute unsigned short angle;
             attribute EventHandler onchange;
           };
+        
+          enum OrientationLockType {
+            "any",
+            "natural",
+            "landscape",
+            "portrait",
+            "portrait-primary",
+            "portrait-secondary",
+            "landscape-primary",
+            "landscape-secondary"
+          };
+
+          enum OrientationType {
+            "portrait-primary",
+            "portrait-secondary" 

```suggestion
            "portrait-secondary" ,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/139#pullrequestreview-198022008

Received on Wednesday, 30 January 2019 11:14:28 UTC