- From: Ms2ger <notifications@github.com>
- Date: Wed, 30 Jan 2019 03:05:16 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 30 January 2019 11:05:39 UTC
Hmm, indeed. The test below doesn't call proto.\[[Set]], and just calls the setter. Should I just add a check for `[OverrideBuiltins]`?
```html
<!DOCTYPE html>
<script>
var ds = document.documentElement.dataset;
var a = new Proxy(Object.getPrototypeOf(ds), {
set(...args) { w(args); return false; },
});
Object.setPrototypeOf(ds, a);
ds.x = "foo";
w(ds.x)
</script>
```
It also turns out WebKit isn't following the spec for the non-`[OverrideBuiltins]` case; it was just messing with my `__proto__` set. Updated the result in https://github.com/heycam/webidl/issues/630#issue-402192460.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/issues/630#issuecomment-458904519
Received on Wednesday, 30 January 2019 11:05:39 UTC