Re: [w3c/screen-orientation] Editorial: Examples section edits (#137)

marcoscaceres approved this pull request.

I think there might still be a tiny bug in the button. See suggestion. The other examples seem fine.

I think we should let Example 1 "cook" 🥘 for a bit... I'm still seeing places were we could make a few tweaks. I'd like to come back and revise it a bit later in the internship. However, we got more fun/pressing things to focus on :)  

> +    const { type, angle } = screen.orientation;
+    console.log(`Orientation type is ${type} & angle is ${angle}.`);
+  }
+  
+  screen.orientation.addEventListener("change", () => {
+    show();
+    updateDetails(document.getElementById("button"));
+  });
+  
+  window.addEventListener("load", () => {
+    show();
+    updateDetails(document.getElementById("button"));
+  });
+  </script>
+  
+  <button onclick="rotate() id="button">

Note that this was still buggy... missing closing quote and we should pass in this.  

```suggestion
  <button onclick="rotate(this)" id="button">
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/137#pullrequestreview-196294743