- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 28 Jan 2019 13:39:02 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/626/review/197270538@github.com>
domenic commented on this pull request. I'm having a hard time getting my head around the correct thing to do in this space, but I hope this is helpful... > @@ -10963,7 +10963,7 @@ is the concatenation of the [=interface=]’s Note: For example, if the [=interface=] is the {{Window}} interface, then the sole object will be this global environment’s window object. 1. If the result of running the [=named property visibility algorithm=] with - property name |P| and object |object| is true, then: + property name |P|, object |object| and object |O| is true, then: Let's remove the types from the call site: "with P, object, and O is true". > 1. If |P| is not a [=supported property name=] of |O|, then return false. - 1. If |O| has an own property named |P|, then return false. + 1. If |propertyHolder| has an own property named |P|, then return false. Note: This will include cases in which |O| has unforgeable properties, This note should now refer to |propertyHolder|, right? > 1. While |prototype| is not null: - 1. If |prototype| is not a [=named properties object=], - and |prototype| has an own property named |P|, then return false. Are we sure that removing this clause is safe for the other 3 or so call sites of "named property visiblity algorithm"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/626#pullrequestreview-197270538
Received on Monday, 28 January 2019 21:39:24 UTC