- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 28 Jan 2019 13:11:40 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 28 January 2019 21:12:01 UTC
domenic approved this pull request. This solves the original problem, but I worry about the way in which it allows "identifiers" like `--`. Technically this doesn't seem to be a showstopper: that's a value class name or object property. It's not a valid argument name, but IDL argument names are not exposed to web developers or the JS engine as far as I can tell. It's still weird though. But, I lean toward just merging this now to solve the CSSOM problem, and if we want to come up with a perfect identifier definition later, we can do so separately. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/612#pullrequestreview-197260832
Received on Monday, 28 January 2019 21:12:01 UTC