Re: [whatwg/fetch] Add Stale While Revalidate Handling (#853)

annevk commented on this pull request.



> @@ -4153,6 +4164,11 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
    `<code>User-Agent</code>`/<a>default `<code>User-Agent</code>` value</a>
    to <var>httpRequest</var>'s <a for=request>header list</a>.
 
+   <li><p>If <var>httpRequest</var>'s <a for=request>allows stale content flag</a> is set and
+   <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">contains</a>
+   <code>Cache-Control: Must-Revalidate</code>, then unset <var>httpRequest</var>'s
+   <a for=request>allows stale content flag</a>.

I'm sorry, I had missed the approach changed substantially (at least I thought there was an enum involved originally). This doesn't quite work. You need to extract the header value and parse/compare it in some manner.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/853#pullrequestreview-197095143

Received on Monday, 28 January 2019 15:26:53 UTC