Re: [w3c/screen-orientation] Editorial: Example 2 (#134)

marcoscaceres commented on this pull request.



>        </p>
       <pre class='example html'>
 &lt;script&gt;
-  var start = function() {
-    document.onfullscreenchange = function() {
-      screen.orientation.lock('natural').then(startInternal);
-    }
-    document.documentElement.requestFullscreen();
+  function ready(){
+    console.log("Now full screen and ready to start, locked to " + screen.orientation.type);

This line is getting a little long, which means that anyone looking at this on a phone will see: 

![screenshot 2019-01-17 21 36 40](https://user-images.githubusercontent.com/870154/51312748-19b6a300-1aa0-11e9-90e3-741b1bff9511.png)

It might be good to:

```JS
  const { type } = screen.orientation;
  console.log("Fullscreen and locked to ${type}. Ready!");
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/134#pullrequestreview-193557943