Re: [w3c/screen-orientation] Editorial: Example 1 (#133)

marcoscaceres commented on this pull request.



>  
-  screen.orientation.addEventListener("change", show);
-  window.onload = show;
+const { type, angle } = screen.orientation
+function show(event) {
+ console.log("Orientation type is " + screen.orientation.type);
+ console.log("Orientation angle is " + screen.orientation.angle);
+ console.log("Event Type is " + event.type)

We should drop showing the event.type, I think. It doesn't really add much. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/133#pullrequestreview-193084812

Received on Wednesday, 16 January 2019 11:15:09 UTC