Re: [whatwg/dom] Ground primitives in agents (#717)

domenic approved this pull request.

LGTM but I think that if we're going to do this, we should really introduce the shorthands I suggest here. That could be a followup, but it might be a good idea to do it right the first time.

>  
 <p>To <dfn noexport>signal a slot change</dfn>, for a <a>slot</a> <var>slot</var>, run these steps:
 
 <ol>
- <li><p>If <var>slot</var> is not in <a>unit of related similar-origin browsing contexts</a>'
- <a>signal slot list</a>, append <var>slot</var> to
- <a>unit of related similar-origin browsing contexts</a>' <a>signal slot list</a>.
+ <li><p>Let <var>agent</var> be the <a>similar-origin window agent</a> to which <var>slot</var>'s
+ <a>relevant Realm</a> belongs.

We may want to consider introducing a shorthand in HTML so you can say "slot's relevant agent".

> @@ -3213,15 +3215,17 @@ objects), which is initially empty.
 <ol>
  <li><p>Unset <a>mutation observer compound microtask queued flag</a>.
 
- <li><p>Let <var>notifyList</var> be a <a for=list>clone</a> of
- <a>unit of related similar-origin browsing contexts</a>' <a>mutation observer list</a>.
+ <li><p>Let <var>agent</var> be the <a>similar-origin window agent</a> <a>current Realm Record</a>
+ belongs to.

"the" before "current Realm Record".

Again we could define "the current agent" in HTML.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/717#pullrequestreview-192306028

Received on Monday, 14 January 2019 18:53:20 UTC