Re: [w3c/screen-orientation] Edits Primary and Secondary orientation definitions (#126)

marcoscaceres requested changes on this pull request.

Couple of little things, but this is looking really good! Much more clear with the table. 

> @@ -35,6 +35,7 @@
       caniuse: "screen-orientation",
     };
     </script>
+    <link rel="stylesheet" type="text/css" href="styles.css">

I'd suggest just inlining style.css instead with a `<style>` element... one less file to deal with. 

> +          One primary orientation will always be determined by the natural
+          orientation of the device and this will then determine the secondary
+          value of its related orientation.
+        </p>
+        <p>
+          For example a device held in its natural portrait orientation would
+          have a current orientation of <a>portrait-primary</a> and its
+          <a>portrait-secondary</a> orientation would be its position when
+          rotated 180°.
+        </p>
+        <p>
+          The <a>user agent</a> can associate the other <code>*-primary</code>
+          and <code>*-secondary</code> values at will. For example, it can be
+          based on the device preferred angles, the user's preferred
+          orientations or the current orientation when the application starts.
+        </p>

In a new paragraph, it would be nice here to introduce the table... "The following table..." Alternatively, you could talk about the table in the first paragraph that you added above. 

> +              </th>
+              <th>
+                Primary Orientation 2
+              </th>
+              <th>
+                Secondary Orientation 2
+              </th>
+            </tr>
+          </thead>
+          <tbody>
+            <tr>
+              <td>
+                Portrait
+              </td>
+              <td>
+                Portrait-primary<br>

nit: link "portrait-primary" etc... 

Using a `<br>` seems a little odd... we probably don't need to fix this now, but we should think about maybe a better way of arranging the cells. It doesn't matter too much tho.  

> +              <td>
+                Portrait-primary<br>
+                <a>User agent</a> to set at either <a>Angle</a> <code>90</code>
+                or <a>Angle</a> <code>270</code>
+              </td>
+              <td>
+                Portrait-secondary<br>
+                Set at the angle not used for portrait-primary
+              </td>
+            </tr>
+          </tbody>
+        </table>
+        <p>
+          A <a>user agent</a> MUST keep the <a>current orientation type</a> and
+          the <a>current orientation angle</a> relation consistent for any
+          given <a>document</a>.

May the table could play a role here in enforcing this consistency?  

> +          orientation of the device and this will then determine the secondary
+          value of its related orientation.
+        </p>
+        <p>
+          For example a device held in its natural portrait orientation would
+          have a current orientation of <a>portrait-primary</a> and its
+          <a>portrait-secondary</a> orientation would be its position when
+          rotated 180°.
+        </p>
+        <p>
+          The <a>user agent</a> can associate the other <code>*-primary</code>
+          and <code>*-secondary</code> values at will. For example, it can be
+          based on the device preferred angles, the user's preferred
+          orientations or the current orientation when the application starts.
+        </p>
+        <table>

Might be nice to give the table a `<caption><dfn>the xxxxx table</dfn></caption>` with a proper name, allowing it to be referenced from within the document. Then you can do, "In `<a>`the xxxxx table</a>" when needed (and also potentially allowing other specs to externally reference the table).  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/126#pullrequestreview-190073420