[w3c/manifest] When converting the JSON to IDL, catch type errors. (#753)

Closes #611

This change (choose one):

* [x] Breaks existing normative behavior (please add label "breaking")
* [ ] Adds new normative requirements
* [ ] Adds new normative recommendations or optional items
* [ ] Makes only editorial changes (only changes informative sections, or
  changes normative sections without changing behavior)
* [ ] Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

* [ ] Safari (link to issue)
* [ ] Chrome (link to issue)
* [ ] Firefox (link to issue)
* [ ] Edge (public signal)

Commit message:

This makes explicit the behaviour we had previously (before converting to IDL), and that implemented by browsers, of falling back to the default value for individual manifest members with a type error, rather than failing the whole conversion, which would be the normal behaviour of the IDL converter.

While labeled as breaking, this should cause the spec to match implementations more closely, since they should not be failing the whole manifest if a single member is invalid.
You can view, comment on, or merge this pull request online at:

  https://github.com/w3c/manifest/pull/753

-- Commit Summary --

  * When converting the JSON to IDL, catch type errors.

-- File Changes --

    M index.html (22)

-- Patch Links --

https://github.com/w3c/manifest/pull/753.patch
https://github.com/w3c/manifest/pull/753.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/753

Received on Thursday, 3 January 2019 07:11:24 UTC