Re: [whatwg/fetch] Fixed Issue-846 : remove URL filesystem scheme (#873)

annevk commented on this pull request.

Thank you, this is great. I've got a couple nits and note that you should feel free to add yourself to the Acknowledgments section.

> @@ -209,7 +209,7 @@ number.
 <h3 id=url>URL</h3>
 
 <p>A <dfn export>local scheme</dfn> is a <a for=url>scheme</a> that is "<code>about</code>",
-"<code>blob</code>", "<code>data</code>", or "<code>filesystem</code>".
+"<code>blob</code>" or "<code>data</code>".

Please keep the Oxford comma before "or".

> @@ -3741,13 +3740,6 @@ with a <i>CORS flag</i> and <i>recursive flag</i>, run these steps:
 
   <p>When in doubt, return a <a>network error</a>.
 
- <dt>"<code>filesystem</code>" <!-- flag below also applies to "indexeddb" -->
- <dd>
-  <p>If <var>request</var>'s <a>sandboxed-storage-area-URLs flag</a> is set,

Could you also remove the definition of "sandboxed-storage-area-URLs flag"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/873#pullrequestreview-206808049

Received on Friday, 22 February 2019 13:11:34 UTC