- From: Adam Rice <notifications@github.com>
- Date: Thu, 21 Feb 2019 04:28:43 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 21 February 2019 12:29:05 UTC
DefaultReaderRead will never resolve after the [[closedPromise]] has rejected, therefore setting _closedOrErrored_ on rejection makes no difference. Rename the variable to just _closed_ and only use it to signal that a read has returned with "done" set to true. Also change the lookups of "done" and "value" in ReadableStreamTee from "? Get" to "! Get" as they can never throw, and pullAlgorithm returning an abrupt completion is not supported anyway. Rearrange the steps slightly to reduce redundant work. Closes #991. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/994 -- Commit Summary -- * In ReadableStreamTee, replace _closedOrErrored_ with _closed_ -- File Changes -- M index.bs (19) M reference-implementation/lib/readable-stream.js (20) -- Patch Links -- https://github.com/whatwg/streams/pull/994.patch https://github.com/whatwg/streams/pull/994.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/994
Received on Thursday, 21 February 2019 12:29:05 UTC