- From: Ms2ger <notifications@github.com>
- Date: Thu, 14 Feb 2019 00:43:18 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/635/review/203621395@github.com>
Ms2ger commented on this pull request. > + 1. Set |instance|.\[[SetPrototypeOf]] as defined in [[#platform-object-setprototypeof]]. + 1. Otherwise, if |interfaces| contains an [=interface=] which + [=support indexed properties|supports indexed properties=], + [=support named properties|named properties=], or both: + 1. Set |instance|.\[[GetOwnProperty]] as defined in + [[#legacy-platform-object-getownproperty]]. + 1. Set |instance|.\[[Set]] as defined in + [[#legacy-platform-object-set]]. + 1. Set |instance|.\[[DefineOwnProperty]] as defined in + [[#legacy-platform-object-defineownproperty]]. + 1. Set |instance|.\[[Delete]] as defined in + [[#legacy-platform-object-delete]]. + 1. Set |instance|.\[[PreventExtensions]] as defined in + [[#legacy-platform-object-preventextensions]]. + 1. Set |instance|.\[[OwnPropertyKeys]] as defined in + [[#legacy-platform-object-ownpropertykeys]]. This is already going wrong in the current spec text, whichever way you read it. I'm happy to fix the "define the attributes/operations" algorithms in a followup, but that's scope creep for this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/635#discussion_r256735206
Received on Thursday, 14 February 2019 08:43:40 UTC