- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 08 Feb 2019 13:18:41 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 8 February 2019 21:19:02 UTC
This seems pretty reasonable to me. I agree we don't usually list return types, and I might lean toward removing that and just keeping the assertion, but I don't mind much either way. I think any assertion that adds clarity is welcome; I wouldn't make a habit of asserting before every return, since it's often redundant, but I can see how this particular case is of interest and merits it. The Infra connection would be https://github.com/whatwg/infra/issues/92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/428#issuecomment-461950168
Received on Friday, 8 February 2019 21:19:02 UTC