- From: Andrea Giammarchi <notifications@github.com>
- Date: Sun, 03 Feb 2019 04:30:17 -0800
- To: w3c/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 3 February 2019 12:30:39 UTC
> I just gave it a try, and it seems to return false on elements in a shadow root Yeah, I don't use Shadow DOM much so I haven't thought about it. The @rniwa solution looks way better but I wonder if that should be a WHATWG proposal instead of just a comment in some discussion, 'cause it's very handy and easily badly replaced (see my suggestion, as example). > a MutationObserver should be cleaned up I think it's unnecessary, like @rniwa suggested, so it'd be unnecessary. Same goes for listeners, the constructor is the place to add these or remove these, while reaction can be different based on the node state. Adding and removing too much on each connect/disconnect is not better, IMO, just slower and, in this case, simply over complicated for no gain. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/webcomponents/issues/550#issuecomment-460047362
Received on Sunday, 3 February 2019 12:30:39 UTC