- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 11 Dec 2019 02:53:05 -0800
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/833/review/330443344@github.com>
marcoscaceres commented on this pull request.
Some drive by comments... I'm a bit concerned about conflating what the OS will handle and what the browser handles when it comes to these images.
Also, just bike-shedding, "monochrome" seems a bit weird as a "purpose". Is that normal nomenclature across different OS? Do we know what Windows uses or iOS?
Irrespective of the above, looks like it's taking shape tho! Nice one, @NotWoods.
> @@ -2810,6 +2813,84 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section id="solid-color-icons">
```suggestion
<section>
```
> </dt>
<dd>
- A user agent can present this icon where space constraints and/or
- color requirements differ from those of the application icon.
+ A user agent can present this icon where an icon with a
+ <a href="#solid-color-icons">solid color</a> is needed. The
We should `dfn` solid color somewhere below.
```suggestion
<a>solid color</a> is needed. The
```
> @@ -2810,6 +2813,84 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section id="solid-color-icons">
+ <h2>
+ Solid color icons
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a single color
+ or gradient, where only the transparency of the icon can be
+ controlled. As web applications should work across multiple
```suggestion
controlled. As web applications need to work across multiple
```
> @@ -2810,6 +2813,84 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section id="solid-color-icons">
+ <h2>
+ Solid color icons
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a single color
+ or gradient, where only the transparency of the icon can be
+ controlled. As web applications should work across multiple
+ platforms, it it possible to indicate that an icon can have a
```suggestion
platforms, it is possible to indicate that an icon can have a
```
> + <section id="solid-color-icons">
+ <h2>
+ Solid color icons
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a single color
+ or gradient, where only the transparency of the icon can be
+ controlled. As web applications should work across multiple
+ platforms, it it possible to indicate that an icon can have a
+ user-agent-specified color applied by adding the <a>monochrome</a>
+ purpose. This allows the platform to ensure that the icon looks well
+ integrated with the platform, and even apply different colors and
+ padding in different places throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT use
Doesn't the OS do the color conversion defined here? Or do we need an algorithm to convert images before we hand them to the OS... that's gonna be tricky.
> + <p>
+ Some platforms enforce that icons be displayed with a single color
+ or gradient, where only the transparency of the icon can be
+ controlled. As web applications should work across multiple
+ platforms, it it possible to indicate that an icon can have a
+ user-agent-specified color applied by adding the <a>monochrome</a>
+ purpose. This allows the platform to ensure that the icon looks well
+ integrated with the platform, and even apply different colors and
+ padding in different places throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT use
+ the red component, green component, or blue component of a pixel. If
+ it has alpha equal to zero, the user agent SHOULD NOT display it.
+ If it the alpha component is greater than zero, the user agent SHOULD
+ display it with any tint.
Does the OS or the UA display these?
> + controlled. As web applications should work across multiple
+ platforms, it it possible to indicate that an icon can have a
+ user-agent-specified color applied by adding the <a>monochrome</a>
+ purpose. This allows the platform to ensure that the icon looks well
+ integrated with the platform, and even apply different colors and
+ padding in different places throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT use
+ the red component, green component, or blue component of a pixel. If
+ it has alpha equal to zero, the user agent SHOULD NOT display it.
+ If it the alpha component is greater than zero, the user agent SHOULD
+ display it with any tint.
+ </p>
+ <p>
+ If no monochrome icon is defined when an icon with a solid icon must
```suggestion
If no <a>monochrome</a> icon is defined when an icon with a solid icon is expected to
```
> + <p>
+ The user agent MAY enlarge the icon by adding additional padding.
+ </p>
+ <p>
+ The user agent MAY add a background of any color behind transparent
+ pixels.
+ </p>
+ <section>
+ <h3>
+ Example usage of solid color icons
+ </h3>
+ <h2 class="icon-title">
+ Usage examples
+ </h2>
+ <div class="icons">
+ <div>
should this be a `<figure>`?
> + </h3>
+ <h2 class="icon-title">
+ Usage examples
+ </h2>
+ <div class="icons">
+ <div>
+ <img src="images/monochrome-icon-plain.svg" alt=
+ "A black icon over a checkerboard background">
+ <div class="icon-title">
+ Image
+ </div>
+ <div>
+ The base image with no color.
+ </div>
+ </div>
+ <div>
As above...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/833#pullrequestreview-330443344
Received on Wednesday, 11 December 2019 10:53:08 UTC