- From: David Bokan <notifications@github.com>
- Date: Thu, 05 Dec 2019 14:51:11 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3ctag/design-reviews/issues/392/562354115@github.com>
> This is definitely an improvement, thanks. I have more specific thoughts about the non-normative note beginning "Limiting matching to word boundaries," which are below. With the following changes, I'd be happy with this text. Thanks for the feedback, we'll make the changes. > The spec needs to list which content types this type of fragment applies to, e.g. does this only work for html? what about plain/text documents? SVG? etc... It's implied to be HTML documents only by section [2.3.4 allowTextFragmentDirectiveFlag](https://wicg.github.io/ScrollToTextFragment/#allow-text-fragment-directive-flag) since it makes the change in the HTML document loading steps. I agree it'd be useful to make this more explicit. Would a non-normative note be sufficient because of the above or does this need to be normative? > @annevk left a comment on WICG/ScrollToTextFragment#70 after it was merged: >> That might be doable, yes, but it would require patching HTML. > > Is there an issue filed on HTML to track this work, @bokand? I believe this was in reply to my suggestion: > Also, w.r.t. target="_self" rel="noopener", could we make a link with a text directive imply noopener semantics? I would think this is preferable to requiring links to add noopener since there are cases where that'll be difficult for the user and generally make this more difficult to use. I just replied on the [PR](https://github.com/WICG/ScrollToTextFragment/pull/70#issuecomment-562351149). I changed my mind on the above, I don't think it's critical to this proposal (details there). I think @annevk's original idea about `target="_self" rel="noopener"` would still be useful. Filed https://github.com/whatwg/html/issues/5134. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/392#issuecomment-562354115
Received on Thursday, 5 December 2019 22:51:13 UTC