- From: Joshua Bell <notifications@github.com>
- Date: Mon, 26 Aug 2019 12:30:59 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 August 2019 19:31:21 UTC
inexorabletash commented on this pull request. Thanks for the PR! One nitpick to fix before merging. > @@ -2455,7 +2455,7 @@ interface IDBDatabase : EventTarget { void close(); [NewObject] IDBObjectStore createObjectStore(DOMString name, - optional IDBObjectStoreParameters options); + optional IDBObjectStoreParameters options = {}); Per the Preview, this causes the rendered IDL in the spec to require scrolling to view. Please adjust the wrapping here (e.g. move the `DOMString name` param down and left) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/292#pullrequestreview-279789500
Received on Monday, 26 August 2019 19:31:21 UTC