- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 26 Aug 2019 08:55:38 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 August 2019 15:56:01 UTC
domenic approved this pull request. I pushed two commits; please take a look. I don't feel too strongly about either of them, but I do think it'd be nice to avoid spreading "resolve with the void value" too far if possible. Otherwise, this mostly LGTM. Remaining things are about maybe adding a note around implementations not always creating the PromiseCapability, and maybe avoiding wording that implies you call the author-overwritable `fetch()`. I'll give this approve for now since it's such a nice improvement over the existing ecosystem, so I'd be happy to see it land. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/772#pullrequestreview-279677201
Received on Monday, 26 August 2019 15:56:01 UTC