- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 23 Aug 2019 11:06:21 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/772/review/279146686@github.com>
domenic commented on this pull request. > 1. Let |R| be the first argument to |onRejected|. 1. Let |reason| be the result of [=converted to an IDL value|converting=] |R| to an IDL value of type {{any}}. 1. If there are no steps that are required to be run if the promise was rejected, then return <emu-val>undefined</emu-val>. 1. Otherwise, return the result of performing any steps that were required to be run if the promise was rejected, with |reason| as the rejection reason. - 1. Return [=!=] [$PerformPromiseThen$](|promise|, |onFulfilled|, |onRejected|). + 1. Let |onRejected| be [=!=] [$CreateBuiltinFunction$](|onRejectedSteps|, « »): + 1. Let |constructor| be |promise|.\[[Promise]].\[[Realm]].\[[Intrinsics]].[[{{%Promise%}}]]. + 1. Let |newCapability| be ? [$NewPromiseCapability$](|constructor|). + 1. Return [=!=] [$PerformPromiseThen$](|promise|.\[[Promise]], |onFulfilled|, |onRejected|, |newCapability|). Well, current "upon fulfillment" etc. usages don't have a return value... that's where you'd use "transforming". But I see you seem to be allowing this to stand in for both, hmm. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/772#discussion_r317244467
Received on Friday, 23 August 2019 18:06:43 UTC