- From: Mattias Buelens <notifications@github.com>
- Date: Tue, 20 Aug 2019 10:44:12 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 20 August 2019 17:44:34 UTC
MattiasBuelens commented on this pull request.
> @@ -389,18 +389,18 @@ function TransformStreamDefaultSinkCloseAlgorithm(stream) {
TransformStreamDefaultControllerClearAlgorithms(controller);
// Return a promise that is fulfilled with undefined on success.
- return flushPromise.then(() => {
+ return PerformPromiseCatch(PerformPromiseThen(flushPromise, () => {
Oh woops, that was actually a typo. The extra `)` on line 403 should have been on line 400 instead.
But you're right, the correct implementation would be to use a single `PerformPromiseThen` call with both handlers. So I *accidentally* fixed a bug. 😅
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1010#discussion_r315819781
Received on Tuesday, 20 August 2019 17:44:34 UTC