Re: [w3c/manifest] fix: purpose member type check + empty string handling (#775)

dominickng approved this pull request.

LGTM

>                </li>
-              <li>If <var>keyword</var> is not one of the <a>icon purposes</a>,
-              or <var>set</var> <a>contains</a> <var>keyword</var>, then
-              <a>issue a developer warning</a> and <a>continue</a>.
+              <li>If |canonicalKeyword| is not one of the [=icon purposes=], or
+              |purposes| [=contains=] |keyword|, then [=issue a developer

FYI: Chrome actually will happily give you back duplicates if we see a valid purpose that is already in the set (we return an array, not a set). It's probably right that the spec doesn't allow duplicates, and we should fix that in Chrome.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/775#pullrequestreview-271270797