- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 11 Oct 2018 12:02:52 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 11 October 2018 19:03:14 UTC
By bundling together the reference implementation using browserify, then evaluating it inside the wpt-runner window context, we fix all the cross-realm issues that have plagued us. This includes promise assimilation (which we had a workaround in place for), as well as Object.prototype identity (came up when testing async iterators) and the presence of DOMException and AbortSignal on the global (came up when testing #744).
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/streams/pull/957
-- Commit Summary --
* Meta: fix realm issues in reference implementation testing setup
-- File Changes --
M reference-implementation/.eslintrc.json (6)
A reference-implementation/lib/index.js (16)
M reference-implementation/package.json (7)
M reference-implementation/run-web-platform-tests.js (79)
-- Patch Links --
https://github.com/whatwg/streams/pull/957.patch
https://github.com/whatwg/streams/pull/957.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/957
Received on Thursday, 11 October 2018 19:03:14 UTC