Hey! Had a chance to take a preliminary look at this... Of the two major features introduced, the event part seems pretty nice; the custom elements integration part raises a lot of major questions. Just focusing on the event part: Q: formdata event is fired last in sequence. This means validation has been done previously. As developers will want to add their own data into the form submission (via formData), would they want to have that data validated? Assuming if programmatically added, then data can be synchronously validated. Q: 'formdata' is synchronous (https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm) which means that it will be possible to submit another form (or the same form) from within the form submission steps with this event. This could lead to problems, and should probably be protected. (Possible options include changing the form submission steps to go in-parallel after firing the submit event and queue the formdata event, or limit re-entrancy by adding a form-submit-in-progress flag or similar. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/305#issuecomment-428242165
Received on Tuesday, 9 October 2018 15:39:41 UTC