- From: Alex Russell <notifications@github.com>
- Date: Tue, 27 Nov 2018 23:21:12 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 28 November 2018 07:21:33 UTC
Thanks all, and sorry for the slow replies. @ricea: So pulling on the`GenericTransformStream` thread and configurability, there's a lot of stuff that these designs inadvertantly expose: - the association with the implicit `transformer` means that something that's participating in this hierarchy has to somehow implement the magical [`isTransformStream`](https://streams.spec.whatwg.org/#is-transform-stream). This type [can't be meaninfully subclassed in script](https://streams.spec.whatwg.org/#ts-default-controller-class). Why is this hierarchy welded shut? What are the extension points to make a BYO transform stream type? - the choices you're making about buffer sizes *might* be right, but sophisticated users might take different views. Where are the extension points for those? - Not having configurable queueing strategies might, again, be the right default choice. But always? In all cases? What about for other types? - Not having up-to-date example code is a pretty bad smell. Can you ping this issue again when things are updated, preferably in the Explainer? Regards -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/282#issuecomment-442345345
Received on Wednesday, 28 November 2018 07:21:33 UTC