Re: [whatwg/fetch] Fix: Appending a header to headers with "request-no-cors" guard (#840)

> So I think this should use https://fetch.spec.whatwg.org/#concept-header-list-get rather than "combined value" and then we need to branch on null. If the existing value happens to be the empty string, we should still append ", " and the given value to it.

Done.

> I think the right fix here would be to remove "combined value" entirely in favor of "get". This would require patching XHR as well. Would you be willing to take that on?

Fine, but let me do that separately.

Also I think this doesn't need tests. This is needed to pass existing tests in https://github.com/web-platform-tests/wpt/tree/master/fetch/api/headers/headers-no-cors.window.js.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/840#issuecomment-442276978