Re: [whatwg/streams] Fix memory leak in pipe loop reference implementation (#968) from Mattias Buelens on 2018-11-24 (public-webapps-github@w3.org from November 2018)

From: Mattias Buelens <notifications@github.com>
Date: Sat, 24 Nov 2018 05:58:16 -0800
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/968/c441369759@github.com>

I know the reference implementation isn't meant to be very optimized, but I still think it shouldn't leak memory like this. (And I don't really want to maintain a fork just to fix this leak for my stream polyfill. 😛 )

Chrome's implementation is not affected. [Its internal `pump`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/streams/ReadableStream.js?l=225&rcl=c6ab3c2387e3d30bb4dd3a7df6f496fdbcdb84b8) does not use the promises returned by `thenPromise` to create a chain. I don't think any other browser has already implemented `pipeTo`, so they cannot be affected yet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/968#issuecomment-441369759

Received on Saturday, 24 November 2018 13:58:38 UTC