- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 20 Nov 2018 15:33:41 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 20 November 2018 23:34:03 UTC
domenic commented on this pull request. > + + <li><p>Let <var>value</var> be the empty string. + + <li><p>Assert: the <a>code point</a> at <var>position</var> within <var>input</var> is U+0022 ("). + + <li><p>Advance <var>position</var> by 1. + + <li> + <p>While true: + + <ol> + <li><p>Append the result of <a>collecting a sequence of code points</a> that are not U+0022 (") + or U+005C (\) from <var>input</var>, given <var>position</var>, to <var>value</var>. + + <li> + <p>If <var>position</var> is not past the end of <var>input</var>, then: It would be simpler to flip this so that you break if position is past the end of input. That would probably also allow you to remove the "continue" step later. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/831#pullrequestreview-177022325
Received on Tuesday, 20 November 2018 23:34:03 UTC