Re: [w3c/manifest] Breaking: Ignore any icon with no recognised purpose. (#741)

marcoscaceres requested changes on this pull request.

Couple of little things... the note probably needs changing tho. 

>          </p>
-        <p>
-          For example, as a <a data-lt="badge purpose">badge</a> or "pinned"
-          icon that is visually distinct, in color or form, from an
-          application's launch icon. The user agent uses the value of the
-          <a>purpose</a> member as a hint to determine where and how an
-          <a>ImageResource</a> is displayed. Unless declared otherwise by the
-          developer, a user agent can use an icon for <a>any purpose</a>.
+        <p class="note">
+          For example, an icon with purpose <code>"badge"</code> may be used as

```suggestion
          For example, an icon with purpose "<a>badge</a>" may be used as
```

>          </p>
-        <p>
-          For example, as a <a data-lt="badge purpose">badge</a> or "pinned"
-          icon that is visually distinct, in color or form, from an
-          application's launch icon. The user agent uses the value of the
-          <a>purpose</a> member as a hint to determine where and how an
-          <a>ImageResource</a> is displayed. Unless declared otherwise by the
-          developer, a user agent can use an icon for <a>any purpose</a>.
+        <p class="note">
+          For example, an icon with purpose <code>"badge"</code> may be used as
+          a <a data-lt="badge purpose">badge</a> or "pinned" icon that is

```suggestion
          a <a data-lt="badge purpose">badge</a> or "<a>pinned</a>" icon that is
```

> @@ -2518,14 +2518,16 @@ <h3>
           When an <a>ImageResource</a> is used as an <dfn>icon</dfn>, a
           developer can hint that the image is intended to serve some special
           purpose in the context of the host OS (i.e., for better integration).
+          User agents SHOULD NOT use an icon other than for its stated purpose.

Do we have a concept of "purpose" defined? 

```suggestion
          User agents SHOULD NOT use an icon other than for its stated <a>purpose</a>.
```

> @@ -2554,42 +2556,52 @@ <h3>
             The user agent is free to display the icon in any context.
           </dd>
         </dl>
+        <p class="note">
+          If an icon contains multiple purposes, it can be used for any of

Maybe: 
> used by the user agent for any of

Otherwise, it's a little unclear if the note is speaking to developers. 

> @@ -2554,42 +2556,52 @@ <h3>
             The user agent is free to display the icon in any context.
           </dd>
         </dl>
+        <p class="note">
+          If an icon contains multiple purposes, it can be used for any of
+          those purposes. If all of the stated purposes are not recognized, the
+          icon is totally ignored. For example, if an icon has purpose

This is a bit contradictory with the SHOULD above. Maybe the above SHOULD needs to be MUST, otherwise this doesn't hold true. 

> @@ -2554,42 +2556,52 @@ <h3>
             The user agent is free to display the icon in any context.
           </dd>
         </dl>
+        <p class="note">
+          If an icon contains multiple purposes, it can be used for any of
+          those purposes. If all of the stated purposes are not recognized, the
+          icon is totally ignored. For example, if an icon has purpose
+          <code>"badge fizzbuzz"</code>, then it may be used as a badge, but if
+          an icon has purpose <code>"fizzbuzz"</code>, then it must be ignored.

This note is sounding very much like conformance requirements - which are already stated above. It should be phased like it's describing behavior to a developer, not giving conformance requirements to an implementer. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/741#pullrequestreview-175610905