Re: [whatwg/fetch] Define the Content-Type header parser (#831)

MattMenke2 commented on this pull request.



> +      U+0022 ("), then:
+
+      <ol>
+       <li><p>Append U+0022 (") to <var>value</var>.
+
+       <li><p>Advance <var>position</var> by 1.
+
+       <li><p>Append the result of <a>collecting a sequence of code points</a> that are not
+       U+0022 (") from <var>input</var>, given <var>position</var>, to <var>value</var>.
+
+       <li>
+        <p>If <var>position</var> is not past the end of <var>input</var>, then:
+
+        <ol>
+         <li><p>Assert: the <a for=/>code point</a> at <var>position</var> within <var>input</var>
+         is U+0022 (").

What about escaped quotes?

> +   <th>Headers (as on the network)
+   <th>Output
+  <tr>
+   <td>
+    <pre><code>
+A: nosniff,
+</code></pre>
+   <td rowspan=2>« "<code>nosniff</code>", "" »
+  <tr>
+   <td>
+    <pre><code>
+A: nosniff
+B: sniff
+A:
+</code></pre>
+  <tr>

Maybe add blank lines before each "real" row.  The rowspan and <pre> tags make it rather difficult to follow this table.  Or just add HTML comments between entries.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/831#pullrequestreview-174446870

Received on Tuesday, 13 November 2018 16:17:34 UTC