Re: [w3c/manifest] chore(.travis): check spec for errors/warnings (#739)

mgiuca approved this pull request.

FYI, I don't know anything about Node or Travis. It looks correct, but I'm not an expert.

Just one comment.

> @@ -0,0 +1,58 @@
+#!/usr/bin/env node
+/*eslint-env node*/
+"use strict";
+const { exec } = require("child_process");
+const handler = require("serve-handler");
+const http = require("http");
+
+/**
+ *
+ * @param {string} cmd A string representing a shell command.
+ */
+function toExecutable(cmd) {

This name is a bit confusing. ("It's generating an executable file?")

How about CommandRunner? Thus, `CommandRunner(cmd).run()`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/739#pullrequestreview-174213348